Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add $recipients property to Config\Email #2427

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Add $recipients property to Config\Email #2427

merged 1 commit into from
Nov 25, 2019

Conversation

dafriend
Copy link
Contributor

Needed so that a recipient can be defined in .env and will be picked up in BaseConfig.

Most useful for automated testing situations.

@dafriend
Add $recipients property to Email Config\Email
8b5f28c 
Needed so that a recipient can be defined in .env
@dafriend dafriend changed the title Add $recipients property to Email Config\Email Add $recipients property to Email Config\Email Nov 22, 2019
@dafriend dafriend changed the title Add $recipients property to Email Config\Email Add $recipients property to Config\Email Nov 22, 2019
@MGatner
Copy link
Member

MGatner commented Nov 25, 2019

Makes sense. It's a little weird the way this class handles config, probably because of the CI3 port, but something to address with the refactor.

@MGatner MGatner merged commit f81f678 into codeigniter4:develop Nov 25, 2019
@dafriend dafriend deleted the email-add-recipients-to-config branch November 25, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dafriend @MGatner